Update x11-dl #378
Merged
Update x11-dl #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is unfortunately not very useful because a user can also apply the fix by running |
|
@tomaka I understand, should we add a warning to the README or something? Or is there any way to force Cargo to update a dependency? If we yank the old version, will it display a warning message? |
|
I suppose one solution would be to yank the old version of x11-dl. |
|
Still, we can merge this PR (without necessarily bumping winit version now). This will ensure any new dependency on winit will not accidentally pull a bad version of x11-dl. No? |
tmfink
pushed a commit
to tmfink/winit
that referenced
this pull request
Jan 5, 2022
Fix Metal memory management and the `canvas_metal_minimal`, `canvas_nanovg`, and `macos_app` examples. `winit` does not create an autorelease pool, so the Metal backend had not taken the presence of one into account. Now the Metal backend creates and flushes autorelease pools as necessary. Closes rust-windowing#334. Closes rust-windowing#376.
madsmtm
pushed a commit
to madsmtm/winit
that referenced
this pull request
Jun 11, 2022
Co-authored-by: amrbashir <amrbashir@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #376.