[Windows] Adjust min_dimensions and max_dimensions using AdjustWindowRectEx. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the wait; you're at the top of my list now. Could you rebase/merge with the current master? |
|
Rebased onto master. |
|
I don't know what's going on with AppVeyor. That looks like a sporadic failure. |
francesca64
reviewed
Apr 13, 2018
| @@ -622,6 +622,14 @@ pub struct WindowWrapper(HWND, HDC); | |||
| // https://github.com/retep998/winapi-rs/issues/396 | |||
| unsafe impl Send for WindowWrapper {} | |||
|
|
|||
| pub unsafe fn adjust_size( | |||
| (x, y): (u32, u32), style: DWORD, ex_style: DWORD, | |||
There was a problem hiding this comment.
Ooh, I never knew you could destructure a tuple in the function parameters. Thanks for teaching me something new today!
|
Thanks! Everything looks good, and it worked great when I tested it on Windows 10. (I won't fuss about not making the documentation change, since the docs sorta need an overhaul soon anyway.) |
|
...whoops, the CHANGELOG entry was under the wrong section from before. I'll have to remember to correct that. |
francesca64
added a commit
to francesca64/winit
that referenced
this pull request
Apr 13, 2018
francesca64
added a commit
that referenced
this pull request
Apr 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #196, although it does not update the documentation as suggested in the comments.