Allow arbitrary ASCII strings as NIF names

rustler_codegen/src/nif.rs

@@ -48,8 +48,12 @@ pub fn transcoder_decorator(nif_attributes: NifAttributes, fun: syn::ItemFn) ->
     let argument_names = create_function_params(inputs.clone());
     let erl_func_name = nif_attributes
         .custom_name
-        .map(|n| syn::Ident::new(n.value().as_str(), Span::call_site()))
-        .unwrap_or_else(|| name.clone());
+        .map(|n| n.value().to_string())
+        .unwrap_or_else(|| name.clone().to_string());
+
+    if !erl_func_name.is_ascii() {
+        panic!("Only ASCII strings are supported as function names");
+    }
 
     quote! {
         #[allow(non_camel_case_types)]

rustler_tests/lib/rustler_test.ex

@@ -121,7 +121,7 @@ defmodule RustlerTest do
   def raise_term_with_atom_error(), do: err()
   def term_with_tuple_error(), do: err()
 
-  def nif_attrs_can_rename(), do: err()
+  def nif_attrs_can_rename!(), do: err()
 
   def add_from_tuple(_tuple), do: err()
   def add_one_to_tuple(_tuple), do: err()

rustler_tests/native/rustler_test/src/test_nif_attrs.rs

@@ -1,4 +1,4 @@
-#[rustler::nif(name = "nif_attrs_can_rename")]
+#[rustler::nif(name = "nif_attrs_can_rename!")]
 pub fn can_rename() -> bool {
     true
 }

rustler_tests/test/nif_attrs_test.exs

@@ -2,6 +2,6 @@ defmodule NifAttrsTest do
   use ExUnit.Case
 
   test "can rename a NIF with an attribute" do
-    assert RustlerTest.nif_attrs_can_rename()
+    assert RustlerTest.nif_attrs_can_rename!()
   end
 end