add support fro tuples in nif macro #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for tuples in a nif function by expanding the nif macro to decode tuple types with the `Decode` trait.
|
Is anybody still working on this? I kinda need this feature. |
philss
approved these changes
Mar 28, 2023
philss
added a commit
that referenced
this pull request
Mar 28, 2023
* Add support for tuples in nif macro This commit adds support for tuples in a nif function by expanding the nif macro to decode tuple types with the `Decode` trait. This was originally written by @denumerate in #520 * Add tests covering decode of tuples in nif macro --------- Co-authored-by: Paul Ricks <paul.ricks@beyondidentity.com>
|
@denumerate thank you for the PR! I added your commit in another one - #527. @jerzywilczek I don't know yet when a new version is going to be release, but you can point to the master branch. Closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for tuples in a nif function by expanding the nif macro to decode tuple types with the
Decodetrait.ISSUE: #519