Implement simple allocator using enif_{alloc,free} #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
force-pushed
the
rustler-alloc
branch
2 times, most recently
from
500cabc to
86bb26f
Compare
filmor
force-pushed
the
rustler-alloc
branch
3 times, most recently
from
4a21c56 to
62aba90
Compare
|
TODO: Check with valgrind what's going on |
devsnek
reviewed
Mar 15, 2024
|
Locally on my Mac M1 both the Rust and Elixir tests are passing fine, so it might be something specific to the CI? |
|
Some notes:
|
filmor
force-pushed
the
rustler-alloc
branch
3 times, most recently
from
70f900a to
182f812
Compare
|
Reading https://github.com/E-xyza/zigler/blob/main/priv/beam/allocator.zig brought the fix, this works now. |
evnu
reviewed
May 3, 2024
Since we can only expect a 64bit alignment from the Erlang allocator, we have to ensure larger alignments by overallocating. The allocator for this case behaves the same way as the zigler "large beam allocator", see https://github.com/E-xyza/zigler/blob/main/priv/beam/allocator.zig. If the alignment is greater than 8, we allocate enough memory to store an additional pointer. The result of the initial allocation is then written immediately before the aligned pointer, which is returned from the allocator. When deallocating, we can retrieve the original pointer and pass it on to `enif_free`.
|
@evnu As requested, added more comments to the allocator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a Rust global allocator using Erlang's
enif_allocandenif_free.Rumor has it that this makes Rust's memory usage show up in
erlang:memory().The tests are currently reproducibly seg-faulting on Linux x86-64 but run through on arm64.