-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import of serde_rustler #586
Conversation
4f9b5d1
to
8a25089
Compare
The CI errors are the same that we have in #581 right now |
On the license: The Copyright (c) 2016 hansihe
+ Copyright (c) 2016-2024 The Contributors of the Rustler Project
+ Serde support derived from `serde_rustler` Copyright (c) 2019-2021 sunny-g @sunny-g Please comment if
@rusterlium/core Please have a look at the approach, it would be nice to get some comments/feedback as this is quite a large chunk of (at least slightly) opionated code to be added to our codebase. |
@filmor sorry for the delay just updated the repo to include an MIT Let me know what else you need - glad to see this getting first-party support! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,112 @@ | |||
encode_jobs = %{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not for now, but maybe later: We should move the benchmarks to rustler_benchmarks
.
3294a57
to
c1e3c37
Compare
7fbd1fb
to
402a92e
Compare
* Replace serde_rustler with rustler::serde Ref rusterlium/rustler#586
Hi all, please have a look. This started as a direct import of https://github.com/sunny-g/serde_rustler/ into our codebase (@sunny-g, thanks again for your work!).
Changes
get_type
SerdeTerm
type to allow usage withoutfrom_term
andto_term
The simple example code now looks like this:
As far as I can see, it's not feasible to completely replace our
Encoder
/Decoder
construction as serde does not allow for a "passthrough" (i.e. we allow aTerm
to be "encoded" toTerm
and vice-versa) and can also not be extended to do that.Issues
License
@sunny-g Your project is missing a license, we'd need one from you to proceed with this. If you don't really care, the simplest would probably to donate your code to the project, but this has to be explicit. If you put it under MIT/Apache license, we'd have to carry your copyright along.