Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix register resource_impl arg and add name override #638

Merged
merged 2 commits into from
Jul 13, 2024
Merged

Fix register resource_impl arg and add name override #638

merged 2 commits into from
Jul 13, 2024

Conversation

filmor
Copy link
Member

@filmor filmor commented Jul 12, 2024 •
edited
Loading

  • Allow overriding the resource type name
  • Add resource type name argument to macro

Fixes #637

@filmor filmor requested a review from a team July 12, 2024 17:15
@filmor filmor merged commit ef20458 into master Jul 13, 2024
10 of 46 checks passed
@filmor filmor deleted the resource-impl-attrs branch July 13, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrogson scrogson scrogson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actually implement attributes on resource_impl
2 participants
@filmor @scrogson