Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

Update GGML dependency #226

Merged
merged 9 commits into from
May 16, 2023
Merged

Conversation

danforbes
Copy link
Contributor

No description provided.

@philpax
Copy link
Collaborator

philpax commented May 15, 2023

I'm looking into the quantisation issue. Would you be able to update the models to use inplace? ggerganov/ggml@3ce3145

@philpax
Copy link
Collaborator

philpax commented May 16, 2023

Realized when I woke up this morning that the quantization-check will fail on v1 f16 models, which should work (as they don't have any quantization). Will need to fix after work.

@philpax
Copy link
Collaborator

philpax commented May 16, 2023

@danforbes are you OK with the state of the PR as-is? Might merge it and do the de/requant stuff in another PR to unblock this.

Copy link
Contributor Author

@danforbes danforbes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏻

@philpax philpax merged commit 7468ee9 into rustformers:main May 16, 2023
@danforbes danforbes deleted the deps/ggml/update branch May 16, 2023 20:43
@hhamud hhamud mentioned this pull request Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants