Convert trait type parameters to associated types #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @csherratt @kvark - does this look ok? |
|
Could you explain a bit on why you are doing it? |
| @@ -27,24 +27,24 @@ use vector::*; | |||
| /// A trait representing an [affine | |||
| /// transformation](https://en.wikipedia.org/wiki/Affine_transformation) that | |||
| /// can be applied to points or vectors. An affine transformation is one which | |||
| pub trait Transform<S: BaseNum, V: Vector<S>, P: Point<S, V>>: Sized { | |||
| pub trait Transform<P: Point>: Sized { | |||
|
Looked through it, looks nice. |
|
This part of the Rust Book is good: https://doc.rust-lang.org/book/associated-types.html |
|
Ok, I'm going to merge this. |
brendanzab
added a commit
that referenced
this pull request
Nov 7, 2015
Convert trait type parameters to associated types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rust-lang/rust#24092 has caused quite a bit of ugliness, but I've tried to work around it as best I can.