Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround rust-lang/rust#41478. #410

Merged
merged 1 commit into from
May 2, 2017
Merged

Workaround rust-lang/rust#41478. #410

merged 1 commit into from
May 2, 2017

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented May 1, 2017

Replace all impl .. for Struct<<A as Angle>::Unitless> by Struct<A::Unitless>.

This allows -Zsave-analysis to work, and I think this is more readable too.

Replace all `impl .. for Struct<<A as Angle>::Unitless>` by
`Struct<A::Unitless>`. This allows -Zsave-analysis to work on nightly, and
I think this is more readable too.
@brendanzab
Copy link
Collaborator

Nice! I have the <T as Trait>::U stuff around in some places because I was having to work around Rust requiring me to be more explicit... maybe that has improved within that time? Would be interesting to see if any more of my annotations could be removed.

@brendanzab brendanzab merged commit bb7d342 into rustgd:master May 2, 2017
@ozkriff
Copy link
Collaborator

ozkriff commented May 2, 2017

@brendanzab Can you publish 0.14.1? :)

@brendanzab
Copy link
Collaborator

Waiting for #411 to pass now! :)

@brendanzab
Copy link
Collaborator

Oh, I remember, it was this issue: rust-lang/rust#24092

@kennytm kennytm deleted the workaround-rust-41478 branch May 2, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants