Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lifetime bounds in higher-ranked lifetimes #62

Merged
merged 1 commit into from
Mar 9, 2018

Conversation

RalfJung
Copy link
Contributor

@RalfJung RalfJung commented Mar 9, 2018

Those bounds are ignored by the compiler, and will trigger an error once rust-lang/rust#48326 lands. According to crater, this is the only crate using these bounds. This patch should make the crate work on nightly again.

However, I have been unable to compile the crate even with nightly 2018-02-25, which does not include the change mentioned above. So, I couldn't compile-test this PR.


This change is Reviewable

Those bounds are ignored by the compiler, and will soon trigger an error.
According to crater, this is the only crate using these bounds.
@Rhuagh
Copy link
Collaborator

Rhuagh commented Mar 9, 2018

Thanks!

Bors r+

bors bot added a commit that referenced this pull request Mar 9, 2018
62: Remove lifetime bounds in higher-ranked lifetimes r=Rhuagh a=RalfJung

Those bounds are ignored by the compiler, and will trigger an error once rust-lang/rust#48326 lands. According to crater, this is the only crate using these bounds. This patch should make the crate work on nightly again.

However, I have been unable to compile the crate even with nightly 2018-02-25, which does not include the change mentioned above. So, I couldn't compile-test this PR.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/rustgd/rhusics/62)
<!-- Reviewable:end -->
@Rhuagh
Copy link
Collaborator

Rhuagh commented Mar 9, 2018

We'll see if it builds on CI :)

@bors
Copy link
Contributor

bors bot commented Mar 9, 2018

Build succeeded

@bors bors bot merged commit 2727673 into rustgd:master Mar 9, 2018
@Rhuagh
Copy link
Collaborator

Rhuagh commented Mar 9, 2018

Looks like it works there atleast

@RalfJung
Copy link
Contributor Author

RalfJung commented Mar 9, 2018

The build failure was caused by rust-lang/rust#48551. That's fixed, but my branch where I develop rust-lang/rust#48326 does not include the fix yet, so I can't test whether this will keep working when my patch lands. However, these are all the occurrences of higher-ranked lifetime bounds that crater found.

Thanks for merging so quickly. :) Please release a new minor version of the create before the patch hits stable (which will take ~9 weeks).

@Rhuagh
Copy link
Collaborator

Rhuagh commented Mar 9, 2018

We will probably release a new major version before that (we have some breaking changes).

@RalfJung
Copy link
Contributor Author

RalfJung commented Mar 9, 2018

AFAIK a new minor version with the fix would be necessary for reverse dependencies that will just do cargo update -- they won't get the new major version automatically, so they would fail to build.

@Rhuagh
Copy link
Collaborator

Rhuagh commented Mar 9, 2018

True, I'll get that out tonight.

@RalfJung
Copy link
Contributor Author

RalfJung commented Mar 9, 2018

I compiled rustc with my patch merged into master, and can confirm that this can build current rhusics master (while it fails on the version without my patch, as expected).

So, looking good :)

@Rhuagh
Copy link
Collaborator

Rhuagh commented Mar 13, 2018

The breaking changes had not been merged to master yet, so this was easier than I thought it would :) Anyways, new minors have been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants