Feature: Add s3 backend #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is for setting up a local dev environment and running the integration tests using s3. It will be dropped when the PR is ready for review
This is the most important part of the s3 code, containing the implementation of the entire s3 backend
This commits simply adds s3 as an option in the choose backend. It's boilerplate, so I split it into its own commit
This could be dropped. I implemented these as sanity checks along the way, when I discovered bugs in my code
Scandiravian
commented
Sep 8, 2023
Comment on lines
+222
to
+224
| fn set_option(&mut self, _option: &str, _value: &str) -> RusticResult<()> { | ||
| todo!() | ||
| } |
There was a problem hiding this comment.
I'm not sure what should be implemented here, so some help on this would be really appreciated
simonsan
added
C-enhancement
|
We recently factored out Thanks a lot! 🚀 |
simonsan
added
the
C-migration
|
I've been somewhat busy the last two weeks, so haven't had time to move the PR yet. Will try to get to it during October 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an S3 backend which improves the drop-in-ability of rustic as a replacement for Restic.
When reviewing the code I highly recommend doing it one commit at a time, since some of these will be dropped before the PR is marked as ready. I have included them to show how I have tested the code.
When the PR is ready for review I will also squash the undropped commits into a single one, as per the contribution guidelines.
closes rustic-rs/rustic_core#10