Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use persist-credentials: false throughout #4

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Dec 6, 2024

We already do this in most of the other Rustls crates, and Zizmor 0.7.0 flags its absence in this repo. As mentioned in the description of this finding:

By default, using actions/checkout causes a credential to be persisted in the checked-out repo's .git/config, so that subsequent git operations can be authenticated.

Subsequent steps may accidentally publicly persist .git/config, e.g. by including it in a publicly accessible artifact via actions/upload-artifact.

However, even without this, persisting the credential in the .git/config is non-ideal unless actually needed.

We don't need it, so turn it off :-)

We already do this in most of the other Rustls crates, and Zizmor 0.7.0
flags[0] its absence in this repo.

[0]: https://woodruffw.github.io/zizmor/audits/#artipacked
@cpu cpu self-assigned this Dec 6, 2024
@cpu cpu requested a review from kpcyrd December 6, 2024 18:50
@cpu
Copy link
Member Author

cpu commented Dec 7, 2024

Thanks!

@cpu cpu merged commit d844970 into rustls:main Dec 7, 2024
3 checks passed
@cpu cpu deleted the cpu-dr-zizmor branch December 7, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants