Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document dependency on http2 feature #163

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Document dependency on http2 feature #163

merged 1 commit into from
Jan 3, 2022

Conversation

tgeoghegan
Copy link
Contributor

Annotates the rustdoc on ConnectorBuilder<WantsProtocols{1,2}>::enable_http2
so that docs.rs will plainly tell users that crate feature http2 must
be enabled.

@tgeoghegan
Document dependency on http2 feature
96e9e19 
Annotates the rustdoc on `ConnectorBuilder<WantsProtocols{1,2}>::enable_http2`
so that docs.rs will plainly tell users that crate feature `http2` must
be enabled.
@tgeoghegan
Copy link
Contributor Author

Preview of what this looks like on Firefox:
image

djc
djc reviewed Jan 3, 2022
View reviewed changes
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's helpful!

@djc djc merged commit 6c9e31b into rustls:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgeoghegan @djc