Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding server name #177

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Conversation

MikailBag
Copy link
Contributor

Original case: kube-rs/kube#991

If I understand correctly, hyper-rustls (and other TLS connectors) is the only place to implement this feature since it is responsible for calling this function.

@MikailBag MikailBag force-pushed the server-name-override branch 2 times, most recently from 76ced6d to da6e451 Compare September 17, 2022 15:39
Signed-off-by: Mikail Bagishov <bagishov.mikail@yandex.ru>
@MikailBag MikailBag marked this pull request as ready for review September 17, 2022 15:49
@MikailBag
Copy link
Contributor Author

CI failure seems unrelated

Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this broadly makes sense. Some improvements suggested below.

src/connector.rs Outdated Show resolved Hide resolved
src/connector.rs Outdated Show resolved Hide resolved
src/connector/builder.rs Outdated Show resolved Hide resolved
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some minor nits left...

src/connector.rs Outdated Show resolved Hide resolved
src/connector/builder.rs Outdated Show resolved Hide resolved
@djc djc merged commit 5a923ec into rustls:main Oct 20, 2022
@MikailBag
Copy link
Contributor Author

Thanks!
It'd be nice to see a new release later this month, if comfortable.

@djc djc mentioned this pull request Oct 26, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants