Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: support CARGO_TARGET_DIR env variable #184

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

MarcoIeni
Copy link
Contributor

@MarcoIeni MarcoIeni commented Dec 16, 2022

Tests don't work if you have a custom CARGO_TARGET_DIR

@MarcoIeni MarcoIeni marked this pull request as ready for review December 16, 2022 10:03
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

tests/tests.rs Outdated

fn client_command() -> Command {
let client_bin_path = examples_dir().join("client");
println!("client_bin_path: {:?}", client_bin_path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the println!() call?

I'd prefer to inline target_dir() into examples_dir() and avoid the bindings in server_command() and client_command() (instead putting the examples_dir().join() directly in the Command::new() call.

@djc djc merged commit 21c4d37 into rustls:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants