Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptor improvements #219

Merged
merged 13 commits into from
Aug 14, 2023
Merged

Acceptor improvements #219

merged 13 commits into from
Aug 14, 2023

Conversation

djc
Copy link
Member

@djc djc commented Aug 14, 2023

Fixes #218 and maybe also addresses #198?

@djc djc requested a review from cpu August 14, 2023 08:58
@djc
Avoid deprecated rustls API
67e558e
@djc
Run CI on a weekly schedule
7617ff3 
Probably don't need daily runs given the amount of changes. Run on Friday
mornings so we can catch clippy changes from Rust releases that happen
on Thursday relatively soon after. Also include merge group support.
@djc
Bump MSRV to 1.63 for socket2 0.5.3
10f3069
@djc djc mentioned this pull request Aug 14, 2023
Closed
cpu
cpu approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the many cleanup commits (and adding cron CI!).

This looks good to me. I had one question about the MSRV increase but I don't think it's blocking.

.github/workflows/build.yml Show resolved Hide resolved
@djc djc merged commit 3ed760a into main Aug 14, 2023
18 checks passed
@djc djc deleted the server-tweaks branch August 14, 2023 12:22
@ousado ousado mentioned this pull request Sep 11, 2023
Open
@cpu cpu mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting ip address of connection
2 participants
@djc @cpu