Backport: Allow additionally parsing \r newlines in PEM files #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
complexspaces
force-pushed
the
backport-line-parsing-changes
branch
from
3bc092b
to
81847b9
Compare
complexspaces
force-pushed
the
backport-line-parsing-changes
branch
from
81847b9
to
05d3e5b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #30 to the 1.x release branch with the intent of releasing
1.0.4with the bugfix as requested here on the project's Discord.For the most part this is a clean cherry-pick and only required an update to the test to match the older API of
read_all.Additionally, this PR includes the release boilerplate for making a
1.0.4release.