Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

key_pair: add function to retrieve signature algorithm #158

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

tindzk
Copy link
Contributor

@tindzk tindzk commented Sep 17, 2023

Purpose

Currently, the alg field is restricted to the crate's scope.

Changes

Provide a public function to access signature algorithm.

Checklist

  • Self-review has been completed
  • Changes are complete and ready for review
  • Changes are covered by existing or new tests

Currently, the `alg` field is restricted to the crate's scope. Provide a
public function to access it.
@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #158 (095633c) into main (31403a4) will increase coverage by 0.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #158      +/-   ##
==========================================
+ Coverage   71.90%   72.24%   +0.33%     
==========================================
  Files           7        7              
  Lines        1876     1888      +12     
==========================================
+ Hits         1349     1364      +15     
+ Misses        527      524       -3     
Files Changed Coverage Δ
src/key_pair.rs 72.27% <100.00%> (+3.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks!

src/key_pair.rs Show resolved Hide resolved
@cpu cpu requested a review from est31 September 18, 2023 13:33
src/key_pair.rs Show resolved Hide resolved
@cpu
Copy link
Member

cpu commented Sep 20, 2023

ci / Documentation (nightly) (pull_request) Failing after 26s

Going to administratively merge this. The num-traits crate fixed the custom_code_classes_in_docs error w/ nightly but it isn't in a released version yet.

@cpu cpu merged commit a5b54f5 into rustls:main Sep 20, 2023
11 of 15 checks passed
@tindzk tindzk deleted the feat/alg branch September 21, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants