Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sni_hostname renamed to server_name #295

Closed
Tracked by #294
cpu opened this issue Mar 22, 2023 · 1 comment
Closed
Tracked by #294

sni_hostname renamed to server_name #295

cpu opened this issue Mar 22, 2023 · 1 comment

Comments

@cpu
Copy link
Member

cpu commented Mar 22, 2023

The upstream Rustls project changed the ServerConnection's sni_hostname function to be named server_name. See rustls/rustls@9b8fa40.

I think it makes sense to duplicate this change in the rustls-ffi API, changing rustls_server_connection_get_sni_hostname to be rustls_server_connection_get_server_name. I think its clearer to match upstream and it would also be consistent with existing fns like rustls_accepted_server_name.

Something like this: cpu@c68e826

@cpu
Copy link
Member Author

cpu commented Mar 22, 2023

Resolved in the rustls-0.21.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant