Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: adjust sni_hostname() -> server_name(). #298

Merged
merged 1 commit into from
Mar 22, 2023
Merged

server: adjust sni_hostname() -> server_name(). #298

merged 1 commit into from
Mar 22, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 22, 2023 •
edited
Loading

This follows the upstream change in Rustls to prefer server_name over sni_hostname. See rustls/rustls@9b8fa40.

Resolves #295

@cpu
server: adjust sni_hostname() -> server_name().
e9f7cde 
This follows the upstream change in Rustls to prefer `server_name` over
`sni_hostname`. See rustls/rustls@9b8fa40.
@jsha
Copy link
Collaborator

jsha commented Mar 22, 2023

Thanks!

@jsha jsha merged commit a76c76d into rustls:rustls-0.21.0 Mar 22, 2023
@cpu cpu deleted the cpu-adjust-sni branch March 22, 2023 18:09
@jsha
Copy link
Collaborator

jsha commented Mar 22, 2023

As a note: I edited the commit message to omit See https://github.com/rustls/rustls/commit/9b8fa40. With GitHub's way of pinging issues and PRs, I generally avoid such pings in commits, since it means forks, other branches, etc. can wind up pinging accidentally.

Of course, having done so I realize that linking to commits has no such pinging problem. Sorry about that!

@cpu
Copy link
Member Author

cpu commented Mar 22, 2023

Of course, having done so I realize that linking to commits has no such pinging problem. Sorry about that!

No worries 👍 Now that you've mentioned it I do recall reading in the upstream rustls CONTRIBUTING.md to avoid linking GitHub issues or PRs: https://github.com/rustls/rustls/blob/main/CONTRIBUTING.md#code-changes It doesn't explicitly mention commits but it seems in keeping with the spirit of the doc to avoid those too. I'll adjust for future contributions.

jsha pushed a commit that referenced this pull request Mar 29, 2023
@cpu @jsha
server: adjust sni_hostname() -> server_name() (#298)
43a9ba6 
This follows the upstream change in Rustls to prefer `server_name` over
`sni_hostname`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpu @jsha