Fix two incompatible types warnings in example code #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `rustls_verify_server_cert_callback` type is defined as returning uint32_t. This uint32_t return is translated by the calling code in rustls-ffi to a `rustls_result`. In client.c we were mistakenly typing the `verify` callback as returnign `enum rustls_result` when it should be `uint32_t`. This commit makes the required adjustment, silencing the warning.
On Linux, `man 2 setsockopt` shows the `optval` argument as being `const void *`. On Windows, `setsockopt`'s `optval` argument is `const char*`. This mismatch produces an incompatible types warning when building the `server.c` example on Windows. The solution is straight-forward. Explicitly cast `optval` to `const char*`. On Windows this is the correct type. On Linux it will be implicitly converted to `const void *` and everyone is happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #235
client.c
The
rustls_verify_server_cert_callbacktype is defined as returninguint32_t.In
client.cwe were mistakenly typing theverifycallback as returningenum rustls_resultwhen it should beuint32_t. This commit makes the required adjustment, silencing the warning.server.c
On Linux,
man 2 setsockoptshows theoptvalargument as beingconst void *. On Windows,setsockopt'soptvalargument isconst char*. This mismatch produces an incompatible types warning when building theserver.cexample on Windows.The solution is straight-forward. Explicitly cast
optvaltoconst char*. On Windows this is the correct type. On Linux it will be implicitly converted toconst void *and everyone is happy.