Fix valgrind job #413
Merged
Fix valgrind job #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`export VALGRIND="valgrind -q"` doesn't work as intended: - in GH actions, environment alterations don't affect subsequent `run` steps - in `tests/client_server.rs`, we require `VALGRIND` to be a single command to execute: no shell expansion takes place so no arguments are allowed
cpu
reviewed
Apr 4, 2024
| @@ -52,8 +52,7 @@ jobs: | |||
| persist-credentials: false | |||
| - name: Install valgrind | |||
| run: sudo apt-get update && sudo apt-get install -y valgrind | |||
| - run: export VALGRIND="valgrind -q" | |||
| - run: make test integration | |||
| - run: VALGRIND=valgrind make test integration | |||
There was a problem hiding this comment.
Good catch 😭 It looks like the VALGRIND env manipulation has been inoperable since it was introduced in 456d64b
cpu
approved these changes
Apr 4, 2024
|
Since this is a simple fix and doesn't involve any non-CI updates I think it's fair to merge without blocking on additional reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export VALGRIND="valgrind -q"doesn't work as intended:runstepstests/client_server.rs, we requireVALGRINDto be a single command to execute: no shell expansion takes place so no arguments are allowed