Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: limit scope of format/format-check #415

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Apr 4, 2024

We don't want .git or target/ or other misc dirs to be subject to these phony targets.

Inspired by ctz fixing the same in the compat repo.

@cpu cpu self-assigned this Apr 4, 2024
@cpu
Copy link
Member Author

cpu commented Apr 4, 2024

This is manifesting as a spurious format failure over in this other branch

@ctz
Copy link
Member

ctz commented Apr 4, 2024

Ah, I think this is now evading the -wholename filter

We don't want `.git` or `target/` or other misc dirs to be subject to
these phony targets.
@cpu
Copy link
Member Author

cpu commented Apr 4, 2024

Ah, I think this is now evading the -wholename filter

Fixed up. I also removed the now-unneeded target dir exclusion.

@cpu
Copy link
Member Author

cpu commented Apr 4, 2024

Simple test-only fix. Going to merge once CI passes so that #414 can be rebased.

@cpu cpu merged commit 4161b1d into rustls:main Apr 4, 2024
21 checks passed
@cpu cpu deleted the cpu-fix-format-scope branch April 4, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants