ci: pin cargo-c version in pkg-config workflow #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent release seems to be causing a regression. Until we've had a chance to dig into the root cause let's pin the version in-use in CI to keep the build passing. I also snuck in an update to print the pkg-config version in-use. I was interested in that data when I wasn't sure if it was the cargo-c update that changed things or if there was an unrelated system image update that bork'd it.
ctz
approved these changes
Jun 19, 2024
|
I think I figured out the issue. I'll revert this pinning + land a fix once I've gotten a better sense of whether the upstream change was intentional or not (and perhaps if there's a way we could make this test rig less brittle). |
|
Sorry for the noise, try to set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent 0.10.0 release seems to be causing a regression. Until we've had a chance to dig into the root cause let's pin the version in-use in CI to keep the build passing.
I also snuck in an update to print the pkg-config version in-use. I was interested in that data when I wasn't sure if it was the cargo-c update that changed things or if there was an unrelated system image update that bork'd it.