lib: allow renamed_and_removed_lints for now #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nightly clippy renamed `thread_local_initializer_can_be_made_const` to `missing_const_for_thread_local`. We can't use the new name on stable; we must keep using the old name to suppress the finding. If we don't allow `renamed_and_removed_lints`, we can't use the old name on nightly; it generates a warning about the new name... Using _both_ names won't work for the same reason, and our setting to allow _unknown_ lints won't help. There's no convenient way to change which name we use based on whether we're building with nightly or not so, for now, let's just allow `renamed_and_removed_lints` :-(
ctz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nightly clippy renamed
thread_local_initializer_can_be_made_consttomissing_const_for_thread_local. E.g see this clippy failure.We can't use the new name on stable; we must keep using the old name to suppress the finding. If we don't allow
renamed_and_removed_lints, we can't use the old name on nightly; it generates a warning about the new name... Using both names won't work for the same reason, and our setting to allow unknown lints won't help.There's no convenient way to change which name we use based on whether we're building with nightly or not so, for now, let's just allow
renamed_and_removed_lints:-( The only alternative I could think of is to ignore the failing nightly clippy task (since it's optional), but that seems crummy too. Alternate ideas welcome!