Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix comment on WebPKI and platform verifier #447

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

jsha
Copy link
Collaborator

@jsha jsha commented Jul 30, 2024

Since the webpki crate is a specific implementation (which is chosen by the platform verifier crate on some platforms), it was confusing to call it out by name. Instead, simplify the comment to say it uses "the default behavior for the current platform."

@jsha jsha requested a review from cpu July 30, 2024 01:05
Since the webpki crate is a specific implementation (which is chosen by the
platform verifier crate on some platforms), it was confusing to call it out by
name. Instead, simplify the comment to say it uses "the default behavior for the
current platform."
@cpu cpu force-pushed the fix-platform-verifiers-comment branch from 1345305 to 21a2cdb Compare July 30, 2024 14:39
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this change makes sense to me 👍

The build was failing because src/rustls.h was out-of-date. I took the liberty of pushing a fix for that, squashed into your original commit. Hope that's OK.

@cpu cpu merged commit 311fba1 into main Jul 30, 2024
50 checks passed
@cpu cpu deleted the fix-platform-verifiers-comment branch July 30, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants