crypto_provider: expose a way to get CSRNG data #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
commented
Sep 9, 2024
cpu
force-pushed
the
cpu-crypto-rand
branch
3 times, most recently
from
0b34c76
to
e6deb8b
Compare
ctz
reviewed
Sep 9, 2024
This is a companion to the existing `try_slice!` macro, but returning a `&mut` slice using `slice::from_raw_parts_mut()` instead of `slice::from_raw_parts()`. Two existing callers to `slice::from_raw_parts_mut()` in `connection.rs` are converted to use the macro.
Prevent unsafety from using with incorrect argument type. Assume `$count` is already a `usize` and let the compiler err otherwise.
This commit adds a `rustls_crypto_provider_random()` fn for filling a buffer with cryptographically secure random data using a specific `rustls_crypto_provider`, and `rustls_default_crypto_provider_random()` for doing the same with the process-wide default.
ctz
approved these changes
Sep 10, 2024
|
This feels small enough to not merit blocking on a review from Jsha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds a
rustls_crypto_provider_random()fn for filling a buffer with cryptographically secure random data using a specificrustls_crypto_provider, andrustls_default_crypto_provider_random()for the same with the process-wide default. Doing so requires adding atry_slice_mut!macro to accompany the existingtry_slice!macro. It's similar in function but returns a&mutslice usingslice::from_raw_parts_mut()instead ofslice::from_raw_parts().This should help with downstream issues like curl/curl#14770 where
rustls-ffistands out as the only TLSvtlsbackend incurlthat can't provide this functionality.