Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: adjust default target, broaden all target #473

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Oct 4, 2024

Previously the default target ('all') built the rustls-ffi static library and the client/server example binaries.

This commit adds a new default target ('default') that only builds the static lib. It also updates 'all' to include integration and connect-tests to truly be all the things.

I've left the Makefile.pkg-config as-is since the purpose of that Makefile is largely to be an example of using cargo-c and pkg-config with the client/server binaries.

Updates #318

@cpu cpu self-assigned this Oct 4, 2024
@cpu cpu marked this pull request as draft October 4, 2024 15:40
@cpu cpu force-pushed the cpu-no-default-test-build branch 2 times, most recently from 06d53b3 to 55cff12 Compare October 4, 2024 15:54
@cpu cpu marked this pull request as ready for review October 4, 2024 16:16
Previously the default target ('all') built the rustls-ffi static
library and the client/server example binaries.

This commit adds a new default target ('default') that only builds the
static lib. It also updates 'all' to include integration and
connect-tests to truly be all the things.
@cpu cpu force-pushed the cpu-no-default-test-build branch from 55cff12 to fc75262 Compare October 4, 2024 16:31
@cpu cpu requested a review from ctz October 4, 2024 16:38
@cpu cpu merged commit 58bb1f0 into rustls:main Oct 4, 2024
40 checks passed
@cpu cpu deleted the cpu-no-default-test-build branch October 4, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants