Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using non-rustls types in the API #2

Closed
Ralith opened this issue Nov 4, 2019 · 5 comments
Closed

Consider using non-rustls types in the API #2

Ralith opened this issue Nov 4, 2019 · 5 comments

Comments

@Ralith
Copy link

Ralith commented Nov 4, 2019

In its current form, this library must be updated for every new rustls release. Given the small size and specific responsibilities, removing the rustls dependency would likely allow the library to remain unchanged for much longer periods, reducing maintenance load. As a straw proposal, DER blobs could be returned as Vec<Vec<u8>>.

@djc
Copy link
Member

djc commented Nov 5, 2019

Plus rustls could have like a TryFrom impl for whatever type you use here?

@ctz
Copy link
Member

ctz commented Feb 24, 2020

I'll probably need to hoist the PEM code out of rustls to achieve this. But that seems like a good idea.

@Ralith
Copy link
Author

Ralith commented Jun 21, 2020

This is currently making it difficult to have a git dependency on rustls, which causes problems like quinn-rs/quinn#805.

@est31
Copy link
Member

est31 commented Oct 16, 2020

👍 I wanted to use this crate with reqwest's rustls mode and call add_root_certificate but reqwest has its own certificate types which abstract over the various backends, so the rustls types aren't helpful here. I guess reqwest doesn't want to become dependent on the version of rustls so it'll likely not want to expose compatibility with rustls types in the API.

@est31 est31 mentioned this issue Oct 16, 2020
est31 added a commit to est31/rustls-native-certs that referenced this issue Oct 16, 2020
This commit puts the load_native_certs function
behind a cargo feature that's turned on by default.

Fixes rustls#2
est31 added a commit to est31/rustls-native-certs that referenced this issue Oct 16, 2020
This commit puts the load_native_certs function
behind a cargo feature that's turned on by default.

Fixes rustls#2
est31 added a commit to est31/rustls-native-certs that referenced this issue Oct 16, 2020
This commit puts the load_native_certs function
behind a cargo feature that's turned on by default.

Fixes rustls#2
@est31
Copy link
Member

est31 commented Oct 16, 2020

#12

@ctz ctz closed this as completed in bf4233f Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants