run clippy on tests, fix findings #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
warning: the item `ptr` is imported redundantly
--> src/entry.rs:1146:9
|
1145 | use super::*;
| -------- the item `ptr` is already imported here
1146 | use core::ptr;
| ^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
```
``` error: the borrowed expression implements the required traits --> tests/runner.rs:20:19 | 20 | .args(&[ | ___________________^ 21 | | "s_server", 22 | | "-cert", 23 | | "test-ca/rsa/end.cert", ... | 32 | | "-rev", 33 | | ]) | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `-D clippy::needless-borrows-for-generic-args` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::needless_borrows_for_generic_args)]` ```
This ensures we lint test code as well.
ctz
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there were some clippy warnings in the CI test output. It looks like rustls-ffi wasn't running clippy on tests and this repo inherited that. I'll fix over there as well but as expected there are a lot more findings to squash. This repo has managed to avoid accruing too many. Let's keep it at zero by adding this to CI.