-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward vectored writes #45
Conversation
Tests seem to get stuck every once in a while. It also happens on |
It seems that due to |
As a performance improvement that doesn't have to block 0.23 release, I'll try to rewrite this test over the weekend (using rustls instead of openssl). |
This early data situation looks weird. Even if I remove the |
I've decided to try rewriting it myself. I opted for simplicity and left the TCP connection doing the bridging between the sync and async world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I have a branch based on tokio-rustls server, but I think it would be nice to use a sync implement. thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
use std::io::Write; | ||
|
||
// write early data | ||
if let Some(mut early_data) = stream.session.early_data() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a little different than what I thought it would be, but it's also good.
I actually think it should be outside the function.
Thank you! |
Allows making use of rustls/rustls#1640.
Supersedes #25
I've also run tests with #44 and it seems to work correctly.
Closes #25
Closes #26