fix: correctly poll alert.write until it finishes #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbr
force-pushed
the
fix-midhandshake-sendalert-short-write-buffer
branch
2 times, most recently
from
9f88483 to
580891a
Compare
jbr
force-pushed
the
fix-midhandshake-sendalert-short-write-buffer
branch
from
580891a to
74f6afb
Compare
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
djc
approved these changes
Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48 identified that #47 did not correctly handle the scenario in which the io has insufficient capacity for the alert, requiring multiple calls to alert.write. This PR introduces a test that exercises the alert writing behavior against a smaller duplex than the alert length. If there's a better way to construct an invalid ClientHello, please let me know. I've confirmed that the test fails without the change to handshake.rs