Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on 32-bit platforms #112

Closed
ofek opened this issue Jul 5, 2023 · 3 comments · Fixed by #113
Closed

Broken on 32-bit platforms #112

ofek opened this issue Jul 5, 2023 · 3 comments · Fixed by #113

Comments

@ofek
Copy link

ofek commented Jul 5, 2023

Targets affected in our CI:

  • i686-unknown-linux-gnu
  • i686-pc-windows-msvc
   Compiling hmac v0.12.1
error[E0080]: evaluation of constant value failed
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-webpki-0.101.0/src/der.rs:246:45
    |
246 | const LONG_FORM_LEN_FOUR_BYTES_MAX: usize = (1 << (8 * 4)) - 1;
    |                                             ^^^^^^^^^^^^^^ attempt to shift left by `32_i32`, which would overflow

note: erroneous constant used
   --> /cargo/registry/src/index.crates.io-6f17d22bba15001f/rustls-webpki-0.101.0/src/der.rs:211:40
    |
211 | pub(crate) const MAX_DER_SIZE: usize = LONG_FORM_LEN_FOUR_BYTES_MAX;
    |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0080`.
error: could not compile `rustls-webpki` (lib) due to previous error
warning: build failed, waiting for other jobs to finish...

Compilation of failed (code 101)
@cpu
Copy link
Member

cpu commented Jul 5, 2023

Thanks for catching this. I'm raising the issue for discussion on what to do next but probably we will want to yank rustls-webpki 0.101.0 and rustls 0.21.3 until this is fixed and a new release cut.

@cpu
Copy link
Member

cpu commented Jul 5, 2023

We've published v0.101.1 to fix this.

@ofek
Copy link
Author

ofek commented Jul 5, 2023

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants