Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustls-webpki to v0.101.1 #1013

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Conversation

paolobarbolini
Copy link
Contributor

Today rustls 0.21.3 came out and it upgraded to rustls-webpki v0.101. They can do this because they don't expose the dependency in their public API, so it's not a breaking change for them to do. This means though that now we have to compile two different versions of the same dependency. This fixes it by realizing the rustls-webpki versions.

@paolobarbolini paolobarbolini changed the title Bump rustls-webpki to 0.101 Bump rustls-webpki to v0.101 Jul 5, 2023
@paolobarbolini
Copy link
Contributor Author

Let's wait the resolution of rustls/webpki#112 before merging

@paolobarbolini paolobarbolini changed the title Bump rustls-webpki to v0.101 Bump rustls-webpki to v0.101.1 Jul 6, 2023
@paolobarbolini
Copy link
Contributor Author

This can now be merged

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for catching it @paolobarbolini

@Jarema Jarema merged commit 2c57e46 into nats-io:main Jul 6, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants