Skip to content

Commit

Permalink
Merge pull request #507 from faern/miow-socketaddr
Browse files Browse the repository at this point in the history
Add advisory on miow SocketAddr casting
  • Loading branch information
Shnatsel authored Dec 2, 2020
2 parents 0eebb48 + 6484507 commit 33df676
Showing 1 changed file with 22 additions and 0 deletions.
22 changes: 22 additions & 0 deletions crates/miow/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "miow"
date = "2020-11-13"
url = "https://github.com/yoshuawuyts/miow/issues/38"
keywords = ["memory", "layout", "cast"]
informational = "unsound"

[versions]
patched = [">= 0.2.2", ">= 0.3.6"]
```

# `miow` invalidly assumes the memory layout of std::net::SocketAddr

The [`miow`](https://crates.io/crates/miow) crate has assumed `std::net::SocketAddrV4`
and `std::net::SocketAddrV6` have the same memory layout as the system C representation
`sockaddr`. It has simply casted the pointers to convert the socket addresses to the
system representation. The standard library does not say anything about the memory
layout, and this will cause invalid memory access if the standard library
changes the implementation. No warnings or errors will be emitted once the
change happens.

0 comments on commit 33df676

Please sign in to comment.