Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial advisory for owning_ref unsoundness #1188

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

Shnatsel
Copy link
Member

@Shnatsel Shnatsel commented Feb 9, 2022

I would appreciate an opinion on whether this should be informational = unsound or not.

Addresses part of #1174 (the unmaintained advisory is still TODO)

@Shnatsel Shnatsel requested a review from alex February 9, 2022 03:03
@Shnatsel
Copy link
Member Author

Shnatsel commented Feb 9, 2022

@noamtashma could you take a look and see if the summary is accurate?

Suggestions or edits are also very welcome.

@noamtashma
Copy link
Contributor

Hi! Looks good to me.
You seem to be missing this issue: Kimundi/owning-ref-rs#71
About an unsoundness regarding implicit constraints in the map functions.

@pinkforest pinkforest added the Unsound Informational / Unsound label Jul 31, 2022
@pinkforest
Copy link
Contributor

@Shnatsel would you be open if I push a commit into your branch to address the comment to get this merged -

Otherwise lgtm from me - We've pinged the author - Kimundi/owning-ref-rs#81

@Shnatsel
Copy link
Member Author

Shnatsel commented Aug 2, 2022

I'll see if I can get around to it. FWIW @pinkforest you should have the rights to push to this branch, it's on this repo instead of a private fork.

@pinkforest
Copy link
Contributor

pinkforest commented Aug 2, 2022

Thanks - Fixed it - looks good to merge :)

@pinkforest pinkforest self-requested a review August 2, 2022 19:18
@Shnatsel
Copy link
Member Author

Shnatsel commented Aug 2, 2022

Thanks!

@Shnatsel Shnatsel merged commit ff384c3 into main Aug 2, 2022
@Shnatsel Shnatsel deleted the owning_ref-unsound branch August 2, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Unsound Informational / Unsound
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants