Add atty potential unsoundness (unaligned read) advisory
#1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinkforest
reviewed
Nov 7, 2022
pinkforest
reviewed
Nov 7, 2022
pinkforest
reviewed
Nov 7, 2022
pinkforest
reviewed
Nov 7, 2022
|
Thanks for the contribution - just couple of tiny cosmetic things please and one format fix :) thanks ❤️ I'll leave this for a week open for anyone to comment as this will cause a lot of traffic |
niluxv
force-pushed
the
atty-unsound-unaligned-read
branch
3 times, most recently
from
498b287
to
0fd6705
Compare
|
Thank you for the suggestions, and sorry for the delay! Addressed them now. |
niluxv
force-pushed
the
atty-unsound-unaligned-read
branch
from
0fd6705
to
24d0005
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1457.
@pinkforest Something like this?