Add advisory URL to RUSTSEC-2021-0019 #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd suggest linking to the original issue. Regarding the URL in the JSON output, that's something we can address separately in a general way. |
|
Do you mean the one I linked above in the advisory database? |
tarcieri
reviewed
Feb 5, 2021
complexspaces
force-pushed
the
add-xcb-url
branch
from
bffcb48
to
be100eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advisories without URLs are slightly disadvantageous to automated consumers of the JSON output of
cargo audit --jsonas any reference to the advisory created automatically has no context for reviewers to learn more.Since there currently is no URL reference for the recently added RUSTSEC-2021-0019 advisory againstThe original issue was linked.xcb, I added the rustsec.org one since it is the most complete, compared to the original issue.