Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report out-of-bounds write in stackvec #847

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Report out-of-bounds write in stackvec #847

merged 1 commit into from
Mar 30, 2021

Conversation

ammaraskar
Copy link
Contributor

Upstream issue: Alexhuszagh/rust-stackvector#2

Been open for more than a month now.

@Shnatsel Shnatsel merged commit 2b53054 into rustsec:main Mar 30, 2021
Alexhuszagh added a commit to Alexhuszagh/rust-stackvector that referenced this pull request Apr 12, 2021
@Alexhuszagh
Proposed fix for rustsec/advisory-db#847
f45657d
@Alexhuszagh
Copy link
Contributor

This should be closed as of this commit, all versions prior to this fix (up till 1.0.8) have been yanked from crates.io, and I've gone further and checked the insert_many is unlikely to be unsound based on size_hint, since it merely uses the lower bound as an optimization, and does bounds checking whenever the number of elements in the in the stackvector exceeds the lower bound hint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ammaraskar @Alexhuszagh @Shnatsel