Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gloo_timers, ambiguous verbage #255

Merged
merged 6 commits into from
Sep 23, 2022
Merged

gloo_timers, ambiguous verbage #255

merged 6 commits into from
Sep 23, 2022

Conversation

simbleau
Copy link
Contributor

Closes #254 by improving verbage

Copy link
Collaborator

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

crates/timers/src/callback.rs Outdated Show resolved Hide resolved
crates/timers/src/callback.rs Outdated Show resolved Hide resolved
crates/timers/src/callback.rs Outdated Show resolved Hide resolved
crates/timers/src/callback.rs Outdated Show resolved Hide resolved
simbleau and others added 4 commits September 22, 2022 20:35
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
Co-authored-by: Muhammad Hamza <muhammadhamza1311@gmail.com>
@simbleau
Copy link
Contributor Author

Ready for re-review @hamza1311

@ranile ranile merged commit 0a4ef06 into rustwasm:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cancelable Timeouts/Intervals
2 participants