Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unmaintained actions-rs/cargo actions in CI workflows #315

Merged
merged 1 commit into from
Mar 4, 2023
Merged

Replace unmaintained actions-rs/cargo actions in CI workflows #315

merged 1 commit into from
Mar 4, 2023

Conversation

striezel
Copy link
Contributor

Basically all of the actions-rs/* actions are unmaintained. See actions-rs/toolchain#216 for more information. Due to their age they generate several warnings in CI runs, for example in https://github.com/rustwasm/gloo/actions/runs/4136537026:

Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

To get rid of some of those warnings the occurrences of actions-rs/cargo are replaced by direct invocations of cargo.

@striezel
Replace unmaintained actions-rs/cargo actions in CI workflows
e938e39 
Basically all of the `actions-rs/*` actions are unmaintained. See
<actions-rs/toolchain#216> for more
information. Due to their age they generate several warnings in
CI runs.

To get rid of some of those warnings the occurrences of
`actions-rs/cargo` are replaced by direct invocations of `cargo`.
ranile
ranile approved these changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ranile ranile merged commit 60b1144 into rustwasm:master Mar 4, 2023
@striezel striezel deleted the actions-rs-cargo-replacement branch March 4, 2023 20:13
seanaye pushed a commit to seanaye/gloo that referenced this pull request Apr 12, 2023
@striezel @seanaye
Replace unmaintained actions-rs/cargo actions in CI workflows (rustwa…
a10a617 
…sm#315)

Basically all of the `actions-rs/*` actions are unmaintained. See
<actions-rs/toolchain#216> for more
information. Due to their age they generate several warnings in
CI runs.

To get rid of some of those warnings the occurrences of
`actions-rs/cargo` are replaced by direct invocations of `cargo`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranile ranile ranile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@striezel @ranile