Total & remaining rows, and csv output for diff. #98
Conversation
data-pup
force-pushed
the
add-diff-summary-pr
branch
from
6484838 to
ea70105
Compare
|
The test build for 1.27.2 seems to have stalled, but it did pass locally. We can try that again after review, but it should work :) |
\o/ Nice! |
| @@ -1119,6 +1121,18 @@ impl Ord for DiffEntry { | |||
| } | |||
| } | |||
|
|
|||
| impl serde::Serialize for DiffEntry { | |||
There was a problem hiding this comment.
Any reason to implement this by hand rather than to use #[derive(Serialize)]?
There was a problem hiding this comment.
Ah! This was implemented manually because the delta value should have its sign shown even if it is positive. The derived implementation matched tests for the negative values, but positive values were missing the +.
If there's a way to do this with serde macros though, I'm happy to follow up and fix that :)
Continued work for #88. This PR adds a total and remaining row to the output of the diff subcommand, as well as emitting CSV output!
I ended up moving a lot of the duplicated work in the text and json emission into the
difffunction itself, which helped make these much more concise as well :)