Skip to content

Commit

Permalink
Remove PartialEq<char> for JsString for now
Browse files Browse the repository at this point in the history
This seems to spark controversy, so removing for now but should be easy enough to still add in the future.
  • Loading branch information
RReverser committed Apr 24, 2019
1 parent bc4a98d commit 680a6bb
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions crates/js-sys/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3679,12 +3679,6 @@ impl PartialEq<str> for JsString {
}
}

impl PartialEq<char> for JsString {
fn eq(&self, other: &char) -> bool {
self.as_char() == Some(*other)
}
}

impl<'a> PartialEq<&'a str> for JsString {
fn eq(&self, other: &&'a str) -> bool {
<JsString as PartialEq<str>>::eq(self, other)
Expand Down

0 comments on commit 680a6bb

Please sign in to comment.