Figure out how to support interfaces with NoInterfaceObject attribute
#893
Labels
frontend:webidl
Issues related to the WebIDL frontend to wasm-bindgen
web-sys
Issues related to the `web-sys` crate
Comments
fitzgen
added
frontend:webidl
This was referenced Apr 3, 2019
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this issue
Apr 12, 2019
This commit enables `[NoInterfaceObject]` annotated interfaces in `web-sys`. The `NoInterfaceObject` attribute means that there's not actually a JS class for the object, but all of its properties and such can still be accessed structually and invoked. This should help provide more bindings for some more common types on the web! Note that this builds on recent features to ensure that `dyn_into` and friends always fail for `NoInterfaceObject` objects because they don't actually have a class. Closes rustwasm#893 Closes rustwasm#1257 Closes rustwasm#1315
alexcrichton
added a commit
to alexcrichton/wasm-bindgen
that referenced
this issue
Apr 15, 2019
This commit enables `[NoInterfaceObject]` annotated interfaces in `web-sys`. The `NoInterfaceObject` attribute means that there's not actually a JS class for the object, but all of its properties and such can still be accessed structually and invoked. This should help provide more bindings for some more common types on the web! Note that this builds on recent features to ensure that `dyn_into` and friends always fail for `NoInterfaceObject` objects because they don't actually have a class. Closes rustwasm#893 Closes rustwasm#1257 Closes rustwasm#1315
|
Any chance of getting a new release cut sometime soon? I've been chomping at the bit for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, we completely skip generating code for any interface that is marked
[NoInterfaceObject]. I think we might want to do something like:structural, since we don't ahve the prototype until we get an instanceJsCast::is_instance_ofalways return false for them, because we don't have access to the constructor without getting an instancecc @alexcrichton @afdw
Here are the 71 interfaces with
[NoInterfaceObject]in our webidlsANGLE_instanced_arraysCoordinatesDeviceAccelerationDeviceRotationRateExceptionEXT_blend_minmaxEXT_color_buffer_floatEXT_color_buffer_half_floatEXT_disjoint_timer_queryExternalEXT_frag_depthEXT_shader_texture_lodEXT_sRGBEXT_texture_filter_anisotropicFontFaceSetIteratorGeolocationGetUserMediaRequestHTMLHyperlinkElementUtilsImageCaptureErrorIntlUtilsListBoxObjectMediaStreamErrorMOZ_debugNavigatorAutomationInformationOES_element_index_uintOES_standard_derivativesOES_texture_floatOES_texture_float_linearOES_texture_half_floatOES_texture_half_float_linearOES_vertex_array_objectPositionPositionErrorPromiseNativeHandlerRTCIdentityProviderRegistrarScrollBoxObjectSVGPathSegSVGPathSegArcAbsSVGPathSegArcRelSVGPathSegClosePathSVGPathSegCurvetoCubicAbsSVGPathSegCurvetoCubicRelSVGPathSegCurvetoCubicSmoothAbsSVGPathSegCurvetoCubicSmoothRelSVGPathSegCurvetoQuadraticAbsSVGPathSegCurvetoQuadraticRelSVGPathSegCurvetoQuadraticSmoothAbsSVGPathSegCurvetoQuadraticSmoothRelSVGPathSegLinetoAbsSVGPathSegLinetoHorizontalAbsSVGPathSegLinetoHorizontalRelSVGPathSegLinetoRelSVGPathSegLinetoVerticalAbsSVGPathSegLinetoVerticalRelSVGPathSegMovetoAbsSVGPathSegMovetoRelTreeBoxObjectTreeViewWEBGL_color_buffer_floatWEBGL_compressed_texture_astcWEBGL_compressed_texture_atcWEBGL_compressed_texture_etcWEBGL_compressed_texture_etc1WEBGL_compressed_texture_pvrtcWEBGL_compressed_texture_s3tcWEBGL_compressed_texture_s3tc_srgbWEBGL_debug_renderer_infoWEBGL_debug_shadersWEBGL_depth_textureWEBGL_draw_buffersWEBGL_lose_contextThe text was updated successfully, but these errors were encountered: