Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some wasm-bindgen-test runtime fixes #1178

Merged
merged 4 commits into from
Jan 14, 2019
Merged

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 14, 2019

See each commit for details!

…jects

Our testing runtime tries to call `Array.prototype.forEach` on this object, so
it had damn well better be a proper array!

Fixes rustwasm#1167
This makes control flow a little easier to follow and avoids wasm->js->wasm
re-entrancy.
Since we are no longer redirecting all console logs, and are instead just
observing them.
@fitzgen fitzgen requested a review from alexcrichton January 14, 2019 22:56
@alexcrichton alexcrichton merged commit 1526d18 into rustwasm:master Jan 14, 2019
@alexcrichton
Copy link
Contributor

🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants