New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser-support: warn about the performance hit of the polyfill #1212

Merged

alexcrichton merged 1 commit into rustwasm:master from Ivshti:master

Jan 28, 2019

Contributor

Ivshti commented Jan 28, 2019

Fixes #1205, kind of.

furthermore:

perhaps this warning should be more visible and also added as a comment to the config itself; users who are taking examples from the crate as a basis need to know this
I still intend on fixing this completely, but other than just forking text-encoding, idk what else can be done; perhaps creating a wrapper to text-encoding called text-encoding-browser/text-encoding/fallthrough which checks if the native APIs are available first


          browser-support: warn about the performance hit of using the polyfill~

b3e97a7

alexcrichton merged commit 03e52c7 into rustwasm:master

Contributor

alexcrichton commented Jan 28, 2019

Looks like a great start to me, thanks! We can continue to iterate on this in-tree as necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet