Support Option with custom enums in JS
#1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
approved these changes
Jan 28, 2019
crates/macro-support/src/parser.rs
Outdated
| @@ -970,6 +984,8 @@ impl MacroParse<()> for syn::ItemEnum { | |||
| lit: syn::Lit::Int(ref int_lit), | |||
| }), | |||
| )) => { | |||
| if !has_discriminant { | |||
| } | |||
There was a problem hiding this comment.
Some strange formatting going on here...
Find a hole automatically to use a sentinel value for `None`, and then just wire everything up! Closes rustwasm#1198
alexcrichton
force-pushed
the
enum-option
branch
from
409ebc8 to
9224455
Compare
fitzgen
added
the
TWiRaWA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find a hole automatically to use a sentinel value for
None, and thenjust wire everything up!
Closes #1198