Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links #1234

Merged
merged 1 commit into from
Feb 10, 2019
Merged

Fix broken links #1234

merged 1 commit into from
Feb 10, 2019

Conversation

gridbugs
Copy link
Contributor

Spotted some broken links. I used mdbook-linkcheck to find more and fixed them. Tested by building locally with mdbook and serving with a static web server.

fitzgen
fitzgen approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

If we are green on the mdbook link checks tool now, it would be cool to hook that into our CI set up, if you're interested in making a follow up PR :)

@fitzgen fitzgen merged commit f6362a6 into rustwasm:master Feb 10, 2019
@gridbugs gridbugs deleted the guide-fix-broken-links branch February 10, 2019 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gridbugs @fitzgen