Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS type for init fn #1412

Merged
merged 1 commit into from
Apr 2, 2019
Merged

Add TS type for init fn #1412

merged 1 commit into from
Apr 2, 2019

Conversation

c410-f3r
Copy link
Contributor

Fixes #1390

Copy link
Contributor

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, thanks for this!

crates/cli-support/src/js/mod.rs Show resolved Hide resolved
crates/typescript-tests/src/web/init.ts Show resolved Hide resolved
crates/cli-support/src/js/mod.rs Outdated Show resolved Hide resolved
@c410-f3r c410-f3r force-pushed the init-ts branch 2 times, most recently from 95ec094 to 41c67a2 Compare April 1, 2019 15:40
@alexcrichton
Copy link
Contributor

Thanks @c410-f3r!

(also feel free to ping on branch updates, unfortunately github doesn't always send updates!)

@alexcrichton alexcrichton merged commit fa674df into rustwasm:master Apr 2, 2019
@c410-f3r c410-f3r deleted the init-ts branch April 6, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants